Login with device on self-hosted instance

cksapp · May 24, 2023, 11:31am

See my recent comment

TL;DR The team is already working to release this one and should be merged and included in a upcoming release hopefully soon.

github.com/bitwarden/clients

Removed self-hosted restriction from Login with Device

bitwarden:master ← bitwarden:PM-1101-passwordless-on-self-hosted

opened 08:48PM - 12 May 23 UTC

trmartin4

+4 -14

## Type of change ``` - [ ] Bug fix - [X] New feature development - [ …] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective We currently do not allow self-hosted customers to use Login with Device. This is due to our notifications not working on self-hosted. We have addressed this with https://github.com/bitwarden/server/pull/2934. This change is to remove the client-side checks that prevented the button from displaying. ## Code changes - **/desktop/src/auth/login/login.component.ts** Replaced `checkSelfHosted()` checks with an explicit `getLoginWithDevice()` call, as that is the only remaining functionality in the `checkSelfHosted()` method - **/libs/angular/src/auth/components/login.component.ts** Removed check for self-hosted from `getLoginWithDevice()` - **selfhosted.json** Changed `showPasswordless` to `true` for self-hosted web client. ## Before you submit - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team - Ensure that all UI additions follow [WCAG AA requirements](https://contributing.bitwarden.com/contributing/accessibility/)