Fix fastmail username generator so that item URI appears in Fastmail

Feature/Fix name:

  • Fixing Fastmail Username Generation

Feature/Fix Description

The Fastmail username generator currently doesn’t use the correct API field to set the name of the domain so that Fastmail can keep track of it. The fix is very simple, and I actually already have a PR in the clients repo:

The mobile repo codebase has essentially the same problem, but it also doesn’t currently set the url: field at all. I followed the Android section of the Contributing Guidelines to set up an environment to make and test the necessary changes. But when I try to build the project for Android, I get the error “Could not determine API level for $(TargetFrameworkVersion) of 'v13.0.” Would a thread here be an appropriate place to debug this issue?

Clients / Repos Affected:

  • Mobile

Timeline to completion (estimate):

ETA: Q4/2023

1 Like

Hi @cubemike99 and thank you for your previous contribution :tada

You might be missing an Android SDK (v33-34). Our docs might be outdated speaking about Android SDK 29. I’ll ask our mobile devs about that.

The one’s I mentioned are for Android 13 and 14.
Let me know if that helps.

Kind regards,

Ah that might be it. I followed the docs to the letter which included installing VS 2019. It also looks like VS 2019 only supports installing up to SDK v30 though the menus. I will start again with a newer version of VS. Thanks for the tips!

Okay, that did the trick.

I have the fix working in the android emulator and on android hardware. The fix only affects 3 lines, only files in /Core, and does not include any UI changes. In this situation, is it sufficient to test only one platform (i.e. Android) before creating a PR?

Awesome, happy to hear you got it running.

As the code for the email forwarders is shared and does not involve any UI changes, a PR without testing iOS is fine.

After code-review the changes will also be tested on both platforms by QA.

Thank you for your work on this.