When I got to login to a website I use Ctrl Shift L first to unlock my vault. This used to open a new tab and I would login then, it would close the tab and have auto filled the email and password. Now when I hit Ctrl Shift L it opens a new Chrome window instead of a tab. Anyway to fix this behaviour?
1 Like
grb
September 22, 2023, 12:47pm
2
@Callum_Shale Welcome to the forum!
For me, this only happens if Iām browsing in Incognito/Private mode. Any chance that is what is happening in your case?
If this is happening when your browser is not in Incognito/Private mode, please provide more detail about which operating system you are using (including version number), as well as the version numbers of your Chrome browser and Bitwarden browser extension.
Hi @grb Thanks!
This is happening whilest not in incognito/private mode.
My OS is - Windows 11 Home 22H2
Thanks for taking the time to look at this.
grb
September 22, 2023, 2:10pm
4
My browser extension is still on version 2023.8.3, which does not exhibit the behavior that you describe.
On further research, it seems that this is an intentional change, introduced in version 2023.9.0, for which the release notes have the following change listed:
Launch unlock or login in new window when auto-filling
The pull request for this ānew featureā development is linked below. If I had to guess (based on the screenshot videos in the PR), this was done so that the new window could be created with a small viewport and location in the upper right corner of the browser (not āupper leftā as stated in the PR description), to mimic the appearance of the browser extension viewport itself.
bitwarden:master ā bitwarden:Client-Integrations/PM-2147-beeep-open-login-form-in-new-window
opened 08:21PM - 05 May 23 UTC
## Type of change
```
- [ ] Bug fix
- [x] New feature development
- [ ] Teā¦ ch debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
```
## Objective
Reimplementing the workflow for how we handle a user who is attempting an autofill when their vault is locked.
With this implementation, we are now opening the password prompt in a window that will always be focused and presented at the top left corner of the currently active browser window. Users can now enter their password in this window and the vault will unlock and autofill the password in the exact same manner as before.
Anytime a user re-attempts a autofill with a locked vault, we first check for existing windows that contain the login form and close them before re-opening the login prompt in the top left corner of the currently active window.
We now also display a notification to the user in the same UI design that is used to display the "Add/Update Cipher" notification. This notification has the ability to re-open the prompt to login to the vault.
## Code changes
- **apps/browser/src/_locales/en/messages.json**: Adding translations for the notification that we're sending to users when they attempt to autofill with a lock vault
- **apps/browser/src/autofill/background/notification.background.ts**: Added a new notification type `UnlockVault` and incorporated behavior for showing/hiding this notification when the user attempts to autofill from the extension with a locked vault. Implemented behavior to ensure that this new notification did not appear when a user was adding a new item, or editing an existing one, from a locked vault.
- **apps/browser/src/autofill/notification/bar.html**: Adding markup required to display the `UnlockVault` notification
- **apps/browser/src/autofill/notification/bar.ts**: Adding content script logic required to display the `UnlockVault` notification and to populate translated content within the markup used to display the notification. Also adding click listeners to the notification that re-open the prompt to unlock a user vault
- **apps/browser/src/background/models/add-unlock-vault-queue-message.ts**: Adding typing information for the `UnlockVault` notification queue.
- **apps/browser/src/background/models/lockedVaultPendingNotificationsItem.ts**: Updating the type information for `LockedVaultPendingNotificationsItem` to ensure that the `msg` value is indicated as an object expecting a `command` key and an optional `data` key
- **apps/browser/src/background/models/notificationQueueMessageType.ts**: Adding `UnlockVault` as a notification queue message type
- **apps/browser/src/background/runtime.background.ts**: Modifying the runtime message listeners that handle prompting the user to login when a vault is locked.
- **apps/browser/src/browser/browserApi.ts**: Added a method for getting a window based on a passed window id. Added a method for opening the Bitwarden login prompt in a new window. Added a method that would close the Bitwarden login prompt.
## Screenshots
https://github.com/bitwarden/clients/assets/16629865/4308fb68-3e89-4da5-9c86-17084dfcdb06
**Example of adding/editing vault items from a locked extension**
https://github.com/bitwarden/clients/assets/16629865/16f6fd14-29c9-4ce9-9607-43f0483fd23d
## Before you submit
- Please add **unit tests** where it makes sense to do so (encouraged but not required)
- If this change requires a **documentation update** - notify the documentation team
- If this change has particular **deployment requirements** - notify the DevOps team
- Ensure that all UI additions follow [WCAG AA requirements](https://contributing.bitwarden.com/contributing/accessibility/)
2 Likes
Where can I deactivate the āfeatureā and return the old behavior? I think it is most annoying. When you close and restore a tab, it will also restore the Bitwarden window. At least in Chrome.
grb
October 17, 2023, 8:45pm
6
@octopus Welcome to the forum.
Bitwarden is working on a new PR to mitigate some of the issues that were caused by PR 5384 :
bitwarden:master ā bitwarden:autofill/pm-4366-update-popout-windows-to-open-as-popup-window-types
opened 10:45PM - 16 Oct 23 UTC
## Type of change
```
- [ ] Bug fix
- [x] New feature development
- [ ] Teā¦ ch debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
```
## Objective
A significant amount of issues have appeared surrounding the work that was done within #5384
These issues include problems such as the following:
- [The UX/UI of the normal window appears bulky and cumbersome](https://github.com/bitwarden/clients/issues/6412#issuecomment-1765243741)
- [In Firefox, opening the popout as a normal window can also open the Bitwarden sidebar along with the vault view](https://github.com/bitwarden/clients/issues/6553#event-10662094813)
- [The popout window will reset/override the position and size of the window when opening a window after an incognito session](https://github.com/bitwarden/clients/issues/6414#issuecomment-1751811787)
- [Browsers can be set to have a tab open with each new window by default, and the popout window opening in a normal context will set up a situation where the window will not close after the user completes a Bitwarden specific action](https://github.com/bitwarden/clients/issues/6583)
These issues all exist due to how we are opening these window elements. We originally set these windows to open as popup type windows, which do not show the URL element. One of our devs noted that because this method of opening a window doesn't show the URL for the extension itself, we open up the possibility of someone spoofing our UI. As a result, we changed these to open as normal windows sow that the URL could be shown in the popout window.
After discussion with the team, we have decided to move forward on opening these windows as `popup` type windows which addresses all of the issues presented above.
We will be exploring more effective ways of mitigating spoofing attempts on the browser extension down the line, but for now given the number of and severity of issues encountered, will be opting to use `popup` window types instead of `normal` window types, even if the URL for the extension does not present itself.
## Code changes
- **apps/browser/src/platform/popup/browser-popout-window.service.ts:** Updating the created window type to `popup` from `normal`. Also updating the dimensions of the created window to more closely reflect the dimensions of the popup window that appears when clicking on the extension icon in the navbar. This will ensure that the visual presentation between these popout windows and the actual popup page are more consistent.
## Demo
https://github.com/bitwarden/clients/assets/16629865/d39816ef-b589-42ff-8ec6-41960de1f5a4
This will not revert to the old behavior, but it will open the unlock prompt in the extensions pop-up bubble instead of in a regular browser window. To revert to the old behavior, you would have to download and install version 2023.8.3 .
Not sure what you are describing here. If you are restoring a tab containing a webpage for which you have āAuto-fill on page loadā enabled, then the behavior is expected. Nonetheless, this type of behavior may also be addressed in an upcoming release.