Clearer error message when vault is out of sync

grb · January 6, 2024, 6:12pm

If anybody wants to do a pull request, the message is hardcoded in the file server/src/Core/Vault/Services/Implementations/CipherService.cs:

github.com

bitwarden/server/blob/c553ec6aa063c5f8c53559b218d622dec6474ca1/src/Core/Vault/Services/Implementations/CipherService.cs#L1016


      
          private void ValidateCipherLastKnownRevisionDateAsync(Cipher cipher, DateTime? lastKnownRevisionDate)
          {
              if (cipher.Id == default || !lastKnownRevisionDate.HasValue)
              {
                  return;
              }
          
              if ((cipher.RevisionDate - lastKnownRevisionDate.Value).Duration() > TimeSpan.FromSeconds(1))
              {
                  throw new BadRequestException(
                      "The cipher you are updating is out of date. Please save your work, sync your vault, and try again."
                  );
              }
          }
          
          private async Task DeleteAttachmentAsync(Cipher cipher, CipherAttachment.MetaData attachmentData)
          {
              if (attachmentData == null || string.IsNullOrWhiteSpace(attachmentData.AttachmentId))
              {
                  return;
              }