✅ Autofill shortcut should open login window when vault is locked

Diede · September 3, 2021, 7:19am

Made an account to request this feature.

andrew2 · September 17, 2021, 10:03am

An Alternative would be for the Right Click menu “BitWarden” to warn at first instance that the vaultis locked.

djsmith85 · October 19, 2021, 5:26pm

Coming soon…

github.com/bitwarden/browser

Unlock on autofill (shortcut and contextMenu)

bitwarden:master ← bitwarden:unlock-on-autofill

opened 04:25PM - 19 Oct 21 UTC

djsmith85

+63 -31

## Type of change - [X] Bug fix - [X] New feature development - [ ] Tech debt… (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Before this change, having a locked vault would cause the following actions to not execute **Keyboard shortcut:** - Ctrl/CMD + Shift + L **Browser contextmenu:** - Auto-Fill - Copy username - Copy password - Copy TOTP To improve the user experience, we now detect if the vault is locked and prompt the user to log in via a new tab. After the user logs in, we close that tab automagically and execute the previous user-selected action. This is the same flow as implemented with #2094 Asana tickets: https://app.asana.com/0/search/1201194531292523/1201228407680432 https://app.asana.com/0/search/1201194531292523/1183005754989927 https://app.asana.com/0/search/1201194531292526/1153357960682206 Closes #645 and #978 Relates to: #1621 and #987 ## Code changes - **src/background/commands.background.ts:** - Added missing types - Add `promptForLogin `and send message to `addToLockedVaultPendingNotifications` - Add messageListener for `unlockCompleted` - **src/background/contextMenus.background.ts:** - Added missing types - Pass `tab` (chrome.tabs.Tab) onto `cipherAction` and onto `startAutofillPage` - removes getting the current tab again - Pass `tab` (chrome.tabs.Tab) onto `getClickedElement` - removes getting the current tab again - Removed noop-action (Vault is locked) and the openPopup - the opening of the popup only worked on certain browsers - Use same login and retry flow as implemented with #2094 - send messages for `promptForLogin` and `addToLockedVaultPendingNotifications` - Add messageListener for `unlockCompleted` - If the vault is locked, the user was not able to select a specific entry, so we now check for the first cipher matching the tabs url. ## Notes for QA All the above mentioned commands or context-menus entries should work as intended, nevermind if the vault was locked or not. ## Before you submit - [X] I have checked for **linting** errors (`npm run lint`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [X] This change requires a **documentation update** (Alert the documentation team in Asana) - [ ] This change has particular **deployment requirements** (Alert DevOps in Asana)

royyyz · November 2, 2020, 8:57pm

Feature name

Enter the name/concept of the feature being requested

Feature function

I use the CMD SHIFT L shortcut to autofill username / password. When I login to Chrome and have been logged out, this shortcut doesn’t work. I suggest that if you are logged out, this shortcut should load the extension and prompt you to enter your master password. This will save a lot of clicks and happens to me daily, so there is high value to this minor fix.

djsmith85 · October 19, 2021, 5:27pm

@tgreer This should be merged with Autofill shortcut should open login window when vault is locked - #63 by djsmith85

xurc · December 1, 2021, 11:12am

I’d love to have this feature in the Firefox extension as well. Currently, the Safari extension will open a new tab if the autofill shortcut is pressed when the vault is locked.

tgreer · December 1, 2021, 3:34pm

@xurc It’ll be available with the next updates in a week or so

xurc · December 1, 2021, 4:04pm

Thank you for the reply, Trey! That’s wonderful news and I really appreciate Bitwarden team’s hard work.

simonfriis · December 10, 2021, 1:06pm

I just had the wonderful experience of pressing the auto-fill shortcut and having a log-in tab open to help me fulfill my task. Very happy to see this implemented.

tgreer · December 10, 2021, 1:23pm

As @simonfriis mentioned, this is now available!!

orc4hire · October 19, 2019, 6:13pm

The one thing that’s driving me a little crazy about Bitwarden is that when the browser extension is locked hitting the shortcut to fill a form just doesn’t do anything. This leads me to hitting the shortcut a couple of times and wondering what’s going on, then finally looking at the toolbar icon and noticing the tiny red dot.

A prompt to unlock when trying to activate the extension would be great.

justn · October 20, 2019, 4:45am

Yes please. As a big advocate for keyboard shortcuts, this is extremely annoying to have to take my hands off of my keyboard and click an icon, and then click the stored login to fill it on the webpage.

And to edit my comment, there is an existing feature request for this behavior here: Autofill shortcut should open login window when vault is locked

ikjadoon · December 16, 2019, 9:48pm

I’m out of votes, but I’d love this feature if it came to Bitwarden.

djsmith85 · December 12, 2021, 11:18am

As @justn mentioned there is another feature request for the same thing. I’m happy to anncounce that it is included in the latest release.