Add option to allow only one instance of the application

pachulo · March 26, 2019, 4:49pm

I’m using the new option of the desktop app to always show a tray icon, but I have a problem using it: when I «hide» the application (using the Shift+Ctrl+M shortcut) and try to restore it by clicking on the launcher, another instance of Bitwarden is spawned and shown, instead of the already running one.

I guess the solution would be to add an option to allow only one instance of the application to run.

I’m using the snap version of the application with Ubuntu 16.04 and Unity 7.

pachulo · September 9, 2019, 10:09am

Well, it seems that this is already the case:

github.com

bitwarden/jslib/blob/e89f295e1d59040bf48ba599a900e3b42497008e/src/electron/window.main.ts#L36




init(): Promise<any> {
    return new Promise((resolve, reject) => {
        try {
            if (!isMacAppStore() && !isSnapStore()) {
                const gotTheLock = app.requestSingleInstanceLock();
                if (!gotTheLock) {
                    app.quit();
                    return;
                } else {
                    app.on('second-instance', (event, commandLine, workingDirectory) => {
                        // Someone tried to run a second instance, we should focus our window.
                        if (this.win != null) {
                            if (this.win.isMinimized() || !this.win.isVisible()) {
                                this.win.show();
                            }
                            this.win.focus();
                        }
                    });
                }
            }

But that it only works when the window is not «hidden» to the system tray…anyone knows why?

pachulo · October 7, 2019, 12:10pm

Opened https://github.com/bitwarden/desktop/issues/324 as I now think that this is a bug.