Add current URL to Entry

aeiro · September 16, 2019, 7:52am

I’ve imported from keepass and most of my passwords have no url attached to them. Currently, in order to associate a URL with an entry, I need to find it, click on the edit button, and manually type the URL in the URL box. Or if I remember, I can copy the URL prior to entering the bitwarden extension flow (If I click on the URL box before doing that, the bitwarden box disappears and my progress gets lost).

catlee · September 21, 2024, 4:14pm

I would love this too!

I took a quick look at implementing this change in the code and discovered these lines:

github.com

bitwarden/clients/blob/main/apps/browser/src/vault/popup/components/vault/add-edit.component.ts#L159-L165


      
          if (!this.editMode) {
            const tabs = await BrowserApi.tabsQuery({ windowType: "normal" });
            this.currentUris =
              tabs == null
                ? null
                : tabs.filter((tab) => tab.url != null && tab.url !== "").map((tab) => tab.url);
          }

If I remove the if (!this.editMode) condition, then the “Toggle current URIs” button appears in the edit dialog just like it does when adding a new item.

This change was introduced here: persist browser context on popout, add uri options input & toggle by mkanavakatini · Pull Request #1290 · bitwarden/clients · GitHub

I’m not sure of the context of why that change was made, and if it’s safe to remove this condition now.

Does @mkanavakatini know?