Add capital letter i to ambiguous characters

jseb · April 28, 2019, 12:00pm

Hi,
The capital letter i should be considered as ambiguous character. Many fonts make it looks like the minor L or the number one. So, to prevent confusion when user wish to export passwords (for printed backup or sharing with a non Bitwarden user - as examples) or copying it anywhere with fonts different from Bitwarden’s ones.

Thanks

bit · April 29, 2019, 3:12am

I’m out of votes, but I agree. I tried modifying the code to take care of this, but I couldn’t find the correct section.

jseb · April 29, 2019, 5:46am

I don’t know if it would help you, because I don’t have any coding knowledges more than the basic of the basic, but I found this :

github.com

bitwarden/jslib/blob/master/src/services/passwordGeneration.service.ts

import * as zxcvbn from 'zxcvbn';

import { CipherString } from '../models/domain/cipherString';
import { GeneratedPasswordHistory } from '../models/domain/generatedPasswordHistory';

import { CryptoService } from '../abstractions/crypto.service';
import {
    PasswordGenerationService as PasswordGenerationServiceAbstraction,
} from '../abstractions/passwordGeneration.service';
import { StorageService } from '../abstractions/storage.service';

import { EEFLongWordList } from '../misc/wordlist';

const DefaultOptions = {
    length: 14,
    ambiguous: false,
    number: true,
    minNumber: 1,
    uppercase: true,
    minUppercase: 0,

This file has been truncated. show original

I scanned through the code’s lines and found somes that look to be about the subject.
Hope it will help

bit · May 1, 2019, 8:28am

Thank you. I updated the bitwarden code to add capital letter ‘i’ to ambiguous characters, and Kyle approved it already.

Should be in the next release.

jseb · May 1, 2019, 8:40am

Thanks for the correction!

bit · May 1, 2019, 11:33pm

You’re welcome! Glad to help.