Feature name:
Extra timeout options
Feature Description
Add 8, 12, and 24 hours timeout options.
Clients / Repos Affected:
- Web
Timeline to completion (estimate):
Done - Awaiting review
Extra timeout options
Add 8, 12, and 24 hours timeout options.
Done - Awaiting review
Thanks @Zadak! @eliykat commented on the PR regarding the translations, thank you for putting this together!
Hi, it’s been a week and nobody checked my new changes yet
No problem! Just making sure it’s on the radar
I’d be particularly interested in getting feedback from Zorak and Brak on this as well, just from an opposing perspective before acceptance . We’re discussing internally (albeit asynchronously) and will get back to you @Zadak , thanks!
Hi @Zadak ,
After some discussion with our product team, here’s where we stand on this particular item. We appreciate the contribution, however at this time we feel expanding these options should squarely fall into the following:
This is also very applicable as we have future enhancements planned for enterprise policies and other things that will rely on these values with a set max. We also try to keep feature parity between clients as much as possible.
If you’re willing to refactor the submission to accommodate a custom type and entry, as well as implement that across all clients (web vault, browser extension, desktop, mobile) we would gladly accept the change; otherwise at the moment we do not have the capacity to accept this change if we need to also implement it for the other clients internally.
A customisable value sounds like the best option to me. People could decide for themselves and it would be uncluttered compared to radio buttons or drop-down boxes to pick one from several fixed options.
I mean, I would like to, however, not really working in whatever frameworks and language they use. Also, sounds like some time needs to be invested. I will just let them do it when they decide it’s important enough (I hope it is, because well…it IS important)
We’ve added a custom vault timeout option in Vault Timeout Policy by Hinton · Pull Request #2048 · bitwarden/browser · GitHub which should help to address this issue.