Use standard confirm() dialogue to prompt user to save new passwords

Native confirm() dialogues

Instead of manipulating the DOM to insert the bitwarden banner on the page

Feature function

  • As bitwarden implements functionality that’s usually native to the browser, using the browser’s native dialogues to prompt users to save passwords makes sense. This way the prompt will look at home on any browser, including mobile ones.
  • Manipulating the DOM is just asking for bugs and the current implementation has plenty of them (it currently avoids blinking/refreshing on a best-effort basis, and may or may not cause increased CPU usage).

Related topics + references

Numerous bug reports

PR that partially addresses them