Better way of detecting form inputs and submissions

I assume since I’m not seeing these features that this hasn’t been merged in yet?

Seems like a slow process, especially since the work is already done. It’s kind of a shame. My renewal for LastPass is 11 days away. It’s looking like I’ll have to spend there again.

Thanks everyone for your continued patience. We do try to consider PRs and work through community contributions as quickly as possible. Please understand that every PR, internally or externally, requires code review(s), security review, product review, QA testing, regression testing (which is not yet fully automated) and deployment planning. We want to ensure we’re releasing a stable and quality product consistently which is indeed a process. We’re always working to improve and streamline these processes, automate what we can; and as we grow, devote more resources to community engagement. With that, yes, PRs such as this will take a little time to get through end-to-end.

We appreciate everything our community does to contribute and make Bitwarden awesome! Thank you!

13 Likes

Great work, I hope this gets added soon and I can finally recommend Bitwarden to friends.

Please let me know if there is anyway I can help or test, I don’t have much coding knowledge though.

3 Likes

I don’t want to sound disrespectful but I just saw the roadmap for 2022 and this (mainly overlay popup) wasn’t included. Is finishing these commits a possibility for Bitwarden if @Folf don’t reply back ?

1 Like

@RzubkHpVG8 no worries - this feature is in the investigation stage at the moment (noted at the top of the roadmap image) and I am sure the team will review @Folf’s generous contribution before additional code is written :+1:

3 Likes

Sorry to ask, but just to be sure - PR means Public Release?

PR stands for “Pull Request” - basically when someone wants new code to be merged in the main code base, thereby adding the feature/function :sunglasses:

3 Likes

It’s been 6 months since the last activity from @Folf on this forum and on GitHub. Should we try to help with the code so the overlay popup “research” can go faster? This seemed the closest we could get to implement the feature.

I have merged both of my branches but I don’t quite remember all work was left to be done. Notifications still haven’t been improved.

The current roadblock is that the popup feature currently doesn’t work in Firefox as it doesn’t allow usage of getBackgroundPage in iframes. This might mean that the cipher listing and password generator need to be reimplemented outside of main angular app, which I’d like to avoid. If anyone has an hint on how to go about this let me know.

6 Likes

@Folf Just wanted to say thank you for actually having made some meaningful contribution to the overlay popup feature, out of the many hundreds/thousands of people who want it but just get annoyed that it’s not already here. Even if you’ve kind of hit a wall, somebody else could come along and pick it up at some point.

I wish I had the skills to jump in and help. Maybe I will someday.

1 Like

Hey @Folf are you still actively working on this one? Did you have any questions for the team?

I still haven’t found a reliable workaround for the issue I mentioned with the overlays, I’ve been seldomly updating the detection branch as I use it personally.

1 Like

Do you have a rough ETA of when this will be merged to the main branch release for Bitwarden?

Hey @agamon you can see the latest status update for this community contribution from Folf above.

Sorry for the banality of the question, but I know nothing about development and github… Is it possible for a normal user to try this version (especially the popup overlay part)? Is there a step by step guide? Thank you and sorry again

1 Like

I can published an updated build, heads up that popups don’t work on Firefox though.

4 Likes